feat: add duration and time_ago to theme #814#815
Open
jjjermiah wants to merge 5 commits intor-lib:mainfrom
Open
feat: add duration and time_ago to theme #814#815jjjermiah wants to merge 5 commits intor-lib:mainfrom
duration and time_ago to theme #814#815jjjermiah wants to merge 5 commits intor-lib:mainfrom
Conversation
…alisation - Remove bracket decoration from builtin_theme and simple_theme; users can add via cli.user_theme (consistent with .bytes/.num pattern) - Normalise difftime to seconds before pretty_sec to avoid unit mismatch - Simplify .time_ago transform (as.POSIXct handles numeric directly) - Expand tests: difftime normalisation + POSIXct/POSIXlt input variants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #814
Created on 2026-04-22 with reprex v2.1.1
no new dependencies, was able to use existing formatters.
i wouldve used
pretty_dtbut noted the issue in in this comment, i could add the missing fxn to the local env and swap out the custom transform